From 02ce28d0863b310773993d28fdef5a2a5673ff5e Mon Sep 17 00:00:00 2001
From: Federico Lolli <federico.lolli@skywarder.eu>
Date: Tue, 21 Nov 2023 18:53:14 +0100
Subject: [PATCH] [SlidingWindow] renamed some variables and fixed unnecessary
 references

---
 src/shared/utils/SlidingWindow.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/shared/utils/SlidingWindow.h b/src/shared/utils/SlidingWindow.h
index 37c0cbc58..2494f623f 100644
--- a/src/shared/utils/SlidingWindow.h
+++ b/src/shared/utils/SlidingWindow.h
@@ -31,25 +31,25 @@ template <typename T, size_t D>
 class SlidingWindow
 {
 public:
-    explicit SlidingWindow() : window({0}), filled(0) {}
+    explicit SlidingWindow() : window({0}), valuesFilled(0) {}
 
     void push(T value)
     {
         shiftWindow(1);
-        filled < D ? filled++ : filled;
+        valuesFilled < D ? valuesFilled++ : valuesFilled;
         setLast(value);
     }
 
-    bool isFull() { return filled == D; }
+    bool isFull() { return valuesFilled == D; }
 
     /**
      * @brief Get the actual number of elements in the window
      */
-    size_t filled() { return filled; }
+    size_t filled() { return valuesFilled; }
 
     T last() { return window[D - 1]; }
 
-    std::array<T, D>& all() { return &window; }
+    std::array<T, D>& all() { return window; }
 
 private:
     inline void setLast(T value) { window[D - 1] = value; }
@@ -62,14 +62,14 @@ private:
      */
     void shiftWindow(size_t n)
     {
-        for (int i = 0; i < D - n; i++)
+        for (size_t i = 0; i < D - n; i++)
         {
             window[i] = window[i + n];
         }
     }
 
     std::array<T, D> window;
-    size_t filled;
+    size_t valuesFilled;
 };
 
 }  // namespace Boardcore
-- 
GitLab