From 04c42677ba36bf976e8266580bcfd3ce5edf7f6d Mon Sep 17 00:00:00 2001
From: Davide Mor <tazdevil971@gmail.com>
Date: Sun, 6 Aug 2023 22:57:19 +0200
Subject: [PATCH] [sx1278] Removed a bunch of old TODOs
---
src/shared/radio/SX1278/SX1278Frontends.h | 2 --
src/tests/radio/sx1278/lora/test-sx1278-bidir.cpp | 2 +-
src/tests/radio/sx1278/lora/test-sx1278-mavlink.cpp | 2 +-
src/tests/radio/sx1278/lora/test-sx1278-simple.cpp | 2 +-
src/tests/radio/sx1278/test-sx1278-bench-gui.cpp | 1 -
5 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/shared/radio/SX1278/SX1278Frontends.h b/src/shared/radio/SX1278/SX1278Frontends.h
index 0086b72a9..e76662712 100644
--- a/src/shared/radio/SX1278/SX1278Frontends.h
+++ b/src/shared/radio/SX1278/SX1278Frontends.h
@@ -40,8 +40,6 @@ public:
bool isOnPaBoost() override { return true; }
int maxInPower() override
{
- // TODO: Set this to a proper value, right now it's just guessed, the
- // datasheet is just too cryptic, fucking chinese datasheet
return 15;
}
diff --git a/src/tests/radio/sx1278/lora/test-sx1278-bidir.cpp b/src/tests/radio/sx1278/lora/test-sx1278-bidir.cpp
index c89191e55..a08f009cb 100644
--- a/src/tests/radio/sx1278/lora/test-sx1278-bidir.cpp
+++ b/src/tests/radio/sx1278/lora/test-sx1278-bidir.cpp
@@ -186,7 +186,7 @@ int main()
printf("\n[sx1278] Configuring sx1278...\n");
if ((err = sx1278->init(config)) != SX1278Lora::Error::NONE)
{
- printf("[sx1278] sx1278->init error: %s\n", "TODO");
+ printf("[sx1278] sx1278->init error\n");
return -1;
}
diff --git a/src/tests/radio/sx1278/lora/test-sx1278-mavlink.cpp b/src/tests/radio/sx1278/lora/test-sx1278-mavlink.cpp
index 3b51df6cb..4bf32e6ba 100644
--- a/src/tests/radio/sx1278/lora/test-sx1278-mavlink.cpp
+++ b/src/tests/radio/sx1278/lora/test-sx1278-mavlink.cpp
@@ -197,7 +197,7 @@ int main()
printf("\n[sx1278] Configuring sx1278...\n");
if ((err = sx1278->init(config)) != SX1278Lora::Error::NONE)
{
- printf("[sx1278] sx1278->init error: %s\n", "TODO");
+ printf("[sx1278] sx1278->init error\n");
return -1;
}
diff --git a/src/tests/radio/sx1278/lora/test-sx1278-simple.cpp b/src/tests/radio/sx1278/lora/test-sx1278-simple.cpp
index 85a2a75ea..2d4bdc75b 100644
--- a/src/tests/radio/sx1278/lora/test-sx1278-simple.cpp
+++ b/src/tests/radio/sx1278/lora/test-sx1278-simple.cpp
@@ -116,7 +116,7 @@ int main()
printf("\n[sx1278] Configuring sx1278...\n");
if ((err = sx1278->init(config)) != SX1278Lora::Error::NONE)
{
- printf("[sx1278] sx1278->init error: %s\n", "TODO");
+ printf("[sx1278] sx1278->init error\n");
return -1;
}
diff --git a/src/tests/radio/sx1278/test-sx1278-bench-gui.cpp b/src/tests/radio/sx1278/test-sx1278-bench-gui.cpp
index 0182e06f2..c07aea5c2 100644
--- a/src/tests/radio/sx1278/test-sx1278-bench-gui.cpp
+++ b/src/tests/radio/sx1278/test-sx1278-bench-gui.cpp
@@ -31,7 +31,6 @@ GUI *gui = nullptr;
void initGUI()
{
- // TODO: This should be in bsp
using GpioUserBtn = Gpio<GPIOA_BASE, 0>;
GpioUserBtn::mode(Mode::INPUT_PULL_DOWN);
--
GitLab