From 32ec1fb45c5fe9b592d914d4ee7925f3732dc9a2 Mon Sep 17 00:00:00 2001 From: Davide Mor <davide.mor@skywarder.eu> Date: Sat, 16 Sep 2023 10:37:46 +0200 Subject: [PATCH] [sx1278] Fixed linting --- src/shared/radio/SX1278/SX1278Common.cpp | 5 ++--- src/shared/radio/SX1278/SX1278Fsk.cpp | 6 +++--- src/shared/radio/SX1278/SX1278Lora.cpp | 2 +- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/shared/radio/SX1278/SX1278Common.cpp b/src/shared/radio/SX1278/SX1278Common.cpp index f779b3711..6591fdefa 100644 --- a/src/shared/radio/SX1278/SX1278Common.cpp +++ b/src/shared/radio/SX1278/SX1278Common.cpp @@ -117,8 +117,6 @@ SX1278Common::IrqFlags SX1278Common::waitForIrqBusy(LockMode &guard, int timeout) { long long start = miosix::getTick(); - IrqFlags ret_irq = 0; - while ((miosix::getTick() - start) < timeout) { // Delay between polls @@ -128,7 +126,8 @@ SX1278Common::IrqFlags SX1278Common::waitForIrqBusy(LockMode &guard, for (unsigned int i = 0; i < 1000 / DELAY; i++) { // Check if some of the interrupts triggered - if ((ret_irq = checkForIrqAndReset(guard, set_irq, reset_irq)) != 0) + IrqFlags ret_irq = checkForIrqAndReset(guard, set_irq, reset_irq); + if (ret_irq != 0) { return ret_irq; } diff --git a/src/shared/radio/SX1278/SX1278Fsk.cpp b/src/shared/radio/SX1278/SX1278Fsk.cpp index 43983114e..4ca766477 100644 --- a/src/shared/radio/SX1278/SX1278Fsk.cpp +++ b/src/shared/radio/SX1278/SX1278Fsk.cpp @@ -367,7 +367,7 @@ bool SX1278Fsk::send(uint8_t *pkt, size_t len) { // The device was invalidated, just do a quick return, nothing else // matters - return -1; + return false; } // Send first segment @@ -393,7 +393,7 @@ bool SX1278Fsk::send(uint8_t *pkt, size_t len) { // The device was invalidated, just do a quick return, nothing else // matters - return -1; + return false; } SPITransaction spi(getSpiSlave(guard_mode.parent())); @@ -413,7 +413,7 @@ bool SX1278Fsk::send(uint8_t *pkt, size_t len) { // The device was invalidated, just do a quick return, nothing else // matters - return -1; + return false; } last_tx = now(); diff --git a/src/shared/radio/SX1278/SX1278Lora.cpp b/src/shared/radio/SX1278/SX1278Lora.cpp index ab598fbf1..e9c4759ae 100644 --- a/src/shared/radio/SX1278/SX1278Lora.cpp +++ b/src/shared/radio/SX1278/SX1278Lora.cpp @@ -356,7 +356,7 @@ bool SX1278Lora::send(uint8_t *pkt, size_t len) { // The device was invalidated, just do a quick return, nothing else // matters - return -1; + return false; } } -- GitLab