From a88c89f3a4eaa7a98af98c002f010c0bb278dad8 Mon Sep 17 00:00:00 2001
From: Matteo Pignataro <matteo.pignataro@skywarder.eu>
Date: Sat, 12 Nov 2022 19:49:49 +0100
Subject: [PATCH] [TaskScheduler] Fixed pipeline

---
 src/shared/scheduler/TaskScheduler.cpp | 2 +-
 src/tests/actuators/test-servo.cpp     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/shared/scheduler/TaskScheduler.cpp b/src/shared/scheduler/TaskScheduler.cpp
index d22747bd9..3b4ae20d3 100644
--- a/src/shared/scheduler/TaskScheduler.cpp
+++ b/src/shared/scheduler/TaskScheduler.cpp
@@ -73,7 +73,7 @@ uint8_t TaskScheduler::addTask(function_t function, uint32_t period,
     uint8_t id = 1;
 
     // Find a suitable id for the new task
-    for (; tasks[id] != nullptr && id < 255; ++id)
+    for (; id < 255 && tasks[id] != nullptr; ++id)
         ;
 
     return addTask(function, period, id, policy, startTick);
diff --git a/src/tests/actuators/test-servo.cpp b/src/tests/actuators/test-servo.cpp
index 893321c20..76736c054 100644
--- a/src/tests/actuators/test-servo.cpp
+++ b/src/tests/actuators/test-servo.cpp
@@ -80,7 +80,7 @@ int main()
 
     // Start a periodic task to move the first three servos
     TaskScheduler scheduler;
-    uint8_t id = scheduler.addTask(&moveServo, 2 * 1000);
+    scheduler.addTask(&moveServo, 2 * 1000);
     scheduler.start();
 
     // Control the fourth servo manually
-- 
GitLab