From b18c77860ea933637f2cb572778b3ba6b71ed9e8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Niccol=C3=B2=20Betto?= <niccolo.betto@skywarder.eu>
Date: Wed, 28 Dec 2022 16:28:24 +0100
Subject: [PATCH] [TaskScheduler] Avoid copying the newly created agenda in
`normalizeTasks`
---
src/shared/scheduler/TaskScheduler.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/shared/scheduler/TaskScheduler.cpp b/src/shared/scheduler/TaskScheduler.cpp
index 844fea5e9..b92b9a642 100644
--- a/src/shared/scheduler/TaskScheduler.cpp
+++ b/src/shared/scheduler/TaskScheduler.cpp
@@ -153,7 +153,7 @@ void TaskScheduler::normalizeTasks()
int64_t currentTick = getTick();
EventQueue newAgenda;
- while (agenda.size() > 0)
+ while (!agenda.empty())
{
Event event = agenda.top();
agenda.pop();
@@ -168,7 +168,7 @@ void TaskScheduler::normalizeTasks()
newAgenda.push(event);
}
- agenda = newAgenda;
+ agenda = std::move(newAgenda);
}
void TaskScheduler::run()
@@ -177,7 +177,7 @@ void TaskScheduler::run()
while (true)
{
- while (agenda.size() == 0 && !shouldStop())
+ while (agenda.empty() && !shouldStop())
condvar.wait(mutex);
// Exit if the ActiveObject has been stopped
--
GitLab