From f8c49e1262dc378072e1899aeebd738e65f17f83 Mon Sep 17 00:00:00 2001
From: Davide Mor <davide.mor@skywarder.eu>
Date: Mon, 20 May 2024 14:17:11 +0000
Subject: [PATCH] [PinObserver] Removed start/stop as they are useless
---
src/shared/utils/PinObserver/PinObserver.cpp | 6 ------
src/shared/utils/PinObserver/PinObserver.h | 20 --------------------
src/tests/test-pinobserver.cpp | 2 ++
3 files changed, 2 insertions(+), 26 deletions(-)
diff --git a/src/shared/utils/PinObserver/PinObserver.cpp b/src/shared/utils/PinObserver/PinObserver.cpp
index 145b5ae79..34e7d00d3 100644
--- a/src/shared/utils/PinObserver/PinObserver.cpp
+++ b/src/shared/utils/PinObserver/PinObserver.cpp
@@ -52,12 +52,6 @@ bool PinObserver::registerPinCallback(miosix::GpioPin pin, PinCallback callback,
return false;
}
-bool PinObserver::start() { return scheduler.start(); }
-
-void PinObserver::stop() { scheduler.stop(); }
-
-bool PinObserver::isRunning() { return scheduler.isRunning(); }
-
PinData PinObserver::getPinData(miosix::GpioPin pin) { return callbacks[pin]; }
void PinObserver::resetPinChangesCount(miosix::GpioPin pin)
diff --git a/src/shared/utils/PinObserver/PinObserver.h b/src/shared/utils/PinObserver/PinObserver.h
index 86cec33f1..b87d58e29 100644
--- a/src/shared/utils/PinObserver/PinObserver.h
+++ b/src/shared/utils/PinObserver/PinObserver.h
@@ -94,26 +94,6 @@ public:
uint32_t detectionThreshold = 1,
bool reverted = false);
- /**
- * @brief Starts the PinObserver's task scheduler.
- *
- * Note that the scheduler is started as soon as the PinObserver is first
- * used.
- *
- * @return Whether the task scheduler was started or not.
- */
- bool start();
-
- /**
- * @brief Stops the PinObserver's task scheduler.
- */
- void stop();
-
- /**
- * @brief True if the PinObserver started correctly.
- */
- bool isRunning();
-
/**
* @brief Returns the information for the specified pin.
*/
diff --git a/src/tests/test-pinobserver.cpp b/src/tests/test-pinobserver.cpp
index 10dd5e987..b8aca2808 100644
--- a/src/tests/test-pinobserver.cpp
+++ b/src/tests/test-pinobserver.cpp
@@ -71,6 +71,8 @@ int main()
observer.registerPinCallback(pin1, std::bind(onTransition, pin1, _1), 10);
observer.registerPinCallback(pin2, std::bind(onTransition, pin2, _1), 10);
+ scheduler.start();
+
while (true)
Thread::sleep(10000);
}
--
GitLab