Follow-up from "[BSP, LyraGS, ARP] LyraGS BSP, Dipswitch driver and ARP-related algorithms"
The following discussions from !263 (merged) should be addressed:
-
@emilio.corigliano started a discussion: Better to pass as input the coordinates and not the GPSData struct
-
@emilio.corigliano started a discussion: Init could be empty for our case (after the usage of reference latitude and longitude from rocket stats). This is because initialAntennaRocketDistance is no more initialized once (could also be renamed)
-
@emilio.corigliano started a discussion: Should be called in a different way
-
@emilio.corigliano started a discussion: Move this check at the beginning of step, checking for all its pre-requisites
-
@emilio.corigliano started a discussion: Remove this magic number and turn it configuration parameter
Task review
-
See if recycled structures are used (such as GPSData, VN300Data, PinData?) and use ones that use and have only the correct data in use. -
See if collapse same data logs into one with index (wrapped log). -
LogAntennaCoordinates is just one but Follower use GPS continously, log! -
LogRocketCoordinates could be logged only when it changes -
See the stepper movement if use the current degree of the stepper or set the target
Edited by Nicolò Caruso