From c07862074817f8a7d7546b2a83bb207e1e066c2e Mon Sep 17 00:00:00 2001
From: Alberto Nidasio <alberto.nidasio@skywarder.eu>
Date: Thu, 20 Apr 2023 22:00:20 +0200
Subject: [PATCH] [InternalADC] Fixed cppcheck error for `V_DDA_VOLTAGE`

---
 src/shared/drivers/adc/InternalADC.cpp | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/shared/drivers/adc/InternalADC.cpp b/src/shared/drivers/adc/InternalADC.cpp
index bf628feb6..c39f7d886 100644
--- a/src/shared/drivers/adc/InternalADC.cpp
+++ b/src/shared/drivers/adc/InternalADC.cpp
@@ -137,7 +137,9 @@ InternalADCData InternalADC::sampleImpl()
         {
             newData.voltage[i] = readChannel(static_cast<Channel>(i));
             newData.voltage[i] =
-                newData.voltage[i] * V_DDA_VOLTAGE / ADC_RESOLUTION;
+                newData.voltage[i] *
+                V_DDA_VOLTAGE  // cppcheck-suppress ConfigurationNotChecked
+                / ADC_RESOLUTION;
         }
     }
 
@@ -161,7 +163,9 @@ InternalADCData InternalADC::sampleImpl()
         if (temperatureRawValue != 0)
         {
             newData.temperature =
-                temperatureRawValue * V_DDA_VOLTAGE / ADC_RESOLUTION;
+                temperatureRawValue *
+                V_DDA_VOLTAGE  // cppcheck-suppress ConfigurationNotChecked
+                / ADC_RESOLUTION;
 
 #ifdef WITHOUT_CALIBRATION
             // Default conversion
@@ -185,9 +189,10 @@ InternalADCData InternalADC::sampleImpl()
         auto vbatVoltageRawValue = readChannel(static_cast<Channel>(VBAT_CH));
         ADC->CCR &= ~ADC_CCR_VBATE;
 
-        // Conversion
         newData.vBat =
-            vbatVoltageRawValue * V_DDA_VOLTAGE / ADC_RESOLUTION * VBAT_DIV;
+            vbatVoltageRawValue *
+            V_DDA_VOLTAGE  // cppcheck-suppress ConfigurationNotChecked
+            / ADC_RESOLUTION * VBAT_DIV;
     }
 
     return newData;
-- 
GitLab