Skip to content
Snippets Groups Projects
Commit 91af12c6 authored by Alberto Nidasio's avatar Alberto Nidasio
Browse files

[Main] Removed remaining TODOs

parent 390e4d73
No related branches found
No related tags found
No related merge requests found
Pipeline #4237 passed
......@@ -36,9 +36,7 @@ static TIM_TypeDef* const ABK_SERVO_TIMER = TIM10;
constexpr Boardcore::TimerUtils::Channel ABK_SERVO_PWM_CH =
Boardcore::TimerUtils::Channel::CHANNEL_1;
// TODO: Fix rotation value
constexpr float ABK_SERVO_ROTATION = 66.4; // [deg] AirBrakes without end stop
// constexpr float ABK_SERVO_ROTATION = 65; // [deg] AirBrakes with end stop
constexpr float ABK_SERVO_MIN_PULSE = 1405; // [deg]
constexpr float ABK_SERVO_MAX_PULSE =
ABK_SERVO_MIN_PULSE - 10 * ABK_SERVO_ROTATION; // [us]
......
......@@ -88,11 +88,7 @@ Boardcore::MavlinkStatus Radio::getMavlinkStatus()
return mavDriver->getStatus();
}
void Radio::logStatus()
{
Logger::getInstance().log(mavDriver->getStatus());
// TODO: Add transceiver status logging
}
void Radio::logStatus() { Logger::getInstance().log(mavDriver->getStatus()); }
Radio::Radio()
{
......
......@@ -473,23 +473,6 @@ mavlink_message_t TMRepository::packSensorsTm(SensorsTMList sensorId,
break;
}
case SensorsTMList::MAV_CURRENT_SENSE_ID: // TODO
{
mavlink_current_tm_t tm;
// auto currentData =
// Sensors::getInstance().getCurrentSensorLastSample();
// tm.timestamp = currentData.timestamp;
strcpy(tm.sensor_id, "5V_CURRENT");
// tm.current = currentData.current;
mavlink_msg_current_tm_encode(RadioConfig::MAV_SYSTEM_ID,
RadioConfig::MAV_COMPONENT_ID, &msg,
&tm);
break;
}
case SensorsTMList::MAV_DPL_PRESS_ID:
{
mavlink_pressure_tm_t tm;
......
......@@ -185,12 +185,12 @@ void HILFlightPhasesManager::printOutcomes()
*/
void HILFlightPhasesManager::updateFlags(FlightPhasesFlags hil_flags)
{
// [TODO] add ifdefs in order to select which flags to take from matlab
// TODO: Add ifdefs in order to select which flags to take from matlab
flagsFlightPhases[FlightPhases::ASCENT] = hil_flags.flag_ascent;
flagsFlightPhases[FlightPhases::FLYING] = hil_flags.flag_flight;
flagsFlightPhases[FlightPhases::BURNING] = hil_flags.flag_burning;
/* Flags PARA1, PARA2 and SIM_AEROBRAKES ignored from matlab */
// Flags PARA1, PARA2 and SIM_AEROBRAKES ignored from matlab
// flagsFlightPhases[SIM_AEROBRAKES] = hil_flags.flag_airbrakes;
// flagsFlightPhases[PARA1] = hil_flags.flag_para1;
// flagsFlightPhases[PARA2] = hil_flags.flag_para2;
......
......@@ -57,7 +57,7 @@ protected:
tempData.velocityDown = matlabData.getZ();
tempData.speed = sqrtf(tempData.velocityNorth * tempData.velocityNorth +
tempData.velocityDown * tempData.velocityDown);
tempData.positionDOP = 0; // TODO: what's this?
tempData.positionDOP = 0;
tempData.fix = (uint8_t)sensorData->gps.fix;
tempData.satellites = (uint8_t)sensorData->gps.num_satellites;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment